feat(widgets): opt-in bundled widget tooltips - #10427
Closed
ibgreen-openai wants to merge 1 commit into
Closed
Conversation
ibgreen-openai
marked this pull request as ready for review
July 8, 2026 13:35
Collaborator
Author
|
@chrisgervang |
chrisgervang
reviewed
Jul 8, 2026
ibgreen-openai
force-pushed
the
codex/widget-tooltip-integration
branch
from
July 8, 2026 20:50
b0003af to
b0084a6
Compare
Collaborator
Author
|
Updated per your feedback: the callback prop is removed from #10414, and this PR now opts standalone built-in button widgets in through the protected member hook. Shared |
chrisgervang
approved these changes
Jul 9, 2026
Collaborator
|
Lgtm, do you have any screenshots of what this looks like? |
59 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #10414.
Applies the themed tooltip renderer to bundled button widgets using the protected member hook:
How It Fits With #10414
#10414 adds the generic
updateWidgetTooltiphelper and protectedonAfterRenderHTML()lifecycle hook, but intentionally does not change bundled widget rendering.This PR adds explicit metadata to button targets:
Each bundled button widget then calls the helper from its class member hook. The helper removes the native
titleafter render and shows the styled deck.gl tooltip instead.Changes
aria-labelanddata-deck-widget-tooltipto sharedIconButton, plus the direct button markup inCompassWidgetandGimbalWidget.Coverage
This PR covers standalone bundled button widgets.
Loading, Timeline, Popup, Stats, and Scrollbar are intentionally unchanged: they are status, range, or panel widgets rather than standalone button widgets, even where they reuse
IconButton. Scale, Geocoder, Info, and ContextMenu do not currently render nativetitletooltip targets.Validation
./node_modules/.bin/tsc -p modules/widgets/tsconfig.json --noEmit./node_modules/.bin/vitest run --project headless test/modules/core/lib/widget-manager.spec.ts test/modules/widgets/widget-tooltip.spec.ts test/modules/widgets/scrollbar-widget.spec.ts test/modules/widgets/selector-widget.spec.ts test/modules/widgets/theme-widget.spec.ts test/modules/widgets/toggle-widget.spec.ts./node_modules/.bin/vitest run --project headless test/modules/widgets/*.spec.ts(79 passed; existingLoadingWidgetasync spinner test also fails on the base branch)yarn buildyarn lint(passes with existing warnings, no errors)